[Bug 504489] Review Request: proguard - Java class file shrinker, optimizer, obfuscator and preverifier

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504489


Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |oget.fedora at gmail.com
         AssignedTo|nobody at fedoraproject.org    |oget.fedora at gmail.com
               Flag|                            |fedora-review?




--- Comment #1 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-06-07 18:08:26 EDT ---
Here are my notes for this package:

- rpmlint is silent.

- koji rawhide build seems fine
   http://koji.fedoraproject.org/koji/taskinfo?taskID=1397983

! Please explain in the specfile as comments what Sources 1-3 are for.

! Not a blocker, but in the docs/ and examples/ directories, there are html,
xml and pro files that refer to /usr/local/. You might want to fix them.

? Any reason why you don't put the jar files directly in /usr/share/java/ ? If
you definitely need to put the jar files in /usr/share/java/proguard/ , can you
replace 
   %{_javadir}/%{name}*
with
   %{_javadir}/%{name}/
in %files to indicate that this is a directory?

* If a package contains a GUI application, then it needs to also include a
properly installed .desktop file. Please follow
   http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
and
   http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

! You need to specify a specific java version in BR and R. See:
  http://fedoraproject.org/wiki/Packaging/Java#BuildRequires_and_Requires
In your case this ought to be 1.5

* GCJ AOT bits SHOULD be built and included in packages. Since this package
builds with java 1.5, this will bring great performance improvements on ppc*
architectures. Please follow:
   http://fedoraproject.org/wiki/Packaging/GCJGuidelines

Can you review my package (bug #504521 )? It is java too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.