[Bug 486804] Review Request: libferrisloki - customized build of Loki library from Modern C++ Design for libferris

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486804





--- Comment #7 from Michael Schwendt <mschwendt at gmail.com>  2009-06-08 07:25:40 EDT ---
* Currently doesn't even build, because the %files section is unmaintained:

error: Installed (but unpackaged) file(s) found:
   /usr/include/FerrisLoki/Extensions.cpp
   /usr/include/FerrisLoki/OrderedStatic.cpp
   /usr/include/FerrisLoki/SafeFormat.cpp
   /usr/include/FerrisLoki/Singleton.cpp
   /usr/include/FerrisLoki/SmallObj.cpp
   /usr/include/FerrisLoki/SmartPtr.cpp
   /usr/include/FerrisLoki/StrongPtr.cpp
   /usr/lib/libferrisloki.a
   /usr/lib/libferrisloki.la

* It would be extremely helpful (not just during review) if you maintained the
spec %changelog and increased the "Release" value with every update of your
package. It's something you would need to do for future updates anyway, so
early practice would be beneficial.

The latest package (from April 13th) is still ferrisloki-3.0.2-50021.src.rpm
with only two changelog entries from 2001 and 2004. What exactly does the 50021
release value mean?

* Fedora's optflags are used, but duplicated, and an appended -O3 -DNDEBUG
overrides them.
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

* https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

* https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

*
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2

* https://fedoraproject.org/wiki/Packaging:ReviewGuidelines

* https://fedoraproject.org/wiki/PackageMaintainers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.