[Bug 504469] Review Request: rubygem-term-ansicolor - Ruby library that colors strings using ANSI escape sequences

bugzilla at redhat.com bugzilla at redhat.com
Mon Jun 8 15:57:06 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504469





--- Comment #6 from Lubomir Rintel <lkundrak at v3.sk>  2009-06-08 11:57:05 EDT ---
(In reply to comment #5)
> Well, 
> - Now build.log complains:
> -------------------------------------------------------------
>     68  warning: File listed twice:
> /usr/lib/ruby/gems/1.8/gems/term-ansicolor-1.0.3/CHANGES
>     69  warning: File listed twice:
> /usr/lib/ruby/gems/1.8/gems/term-ansicolor-1.0.3/GPL
>     70  warning: File listed twice:
> /usr/lib/ruby/gems/1.8/gems/term-ansicolor-1.0.3/README.en
>     71  warning: File listed twice:
> /usr/lib/ruby/gems/1.8/gems/term-ansicolor-1.0.3/VERSION
> --------------------------------------------------------------

I am aware of this and believe that it is ok. Makes no real harm and saves me
from enumerating the contents of the directory just to avoid duplicate
listings.

>   And as you did so before %geminstdir/examples should be marked as
>   %doc.

Will fix (for other packages as well).

>   So %files should be:
> --------------------------------------------------------------
> %files
> %defattr(-,root,root,-)
> 
> %dir %{geminstdir}
> %doc %{geminstdir}/[A-Z]*
> %doc %{geminstdir}/examples/
> %{geminstdir}/*.rb
> %{geminstdir}/lib/
> 
> %doc %{gemdir}/doc/%{gemname}-%{version}/
> %{gemdir}/cache/%{gemname}-%{version}.gem
> %{gemdir}/specifications/%{gemname}-%{version}.gemspec
> ---------------------------------------------------------------
>   thoughts?  

I can do this (and for other packages as well) if you insist on eliminate of
"listed twice" warning but I'll prefer not to.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list