[Bug 504809] Review Request: system-config-selinux - SELinux configuration GUI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504809





--- Comment #2 from Roman Rakus <rrakus at redhat.com>  2009-06-09 11:47:00 EDT ---
>Quick overview before deeper review (I'll finish it later):
>- version (2.0.62) and release (13) don't match changelog ones (1.0.0-1)
fixed
>- inconsistent usage of %{buildroot} and $RPM_BUILD_ROOT - use only one
used %{buildroot}
>- use lowercase SPEC filename
It is lowercase. Just uploaded file on fedoraproject.org/wiki starts with
uppercase character. I don't know why. But finally it will be lowercase.
>- no %doc
It has not any doc

>RPMLint
>rpmlint System-config-selinux.spec
>System-config-selinux.spec: E: no-cleaning-of-buildroot %install
fixed
>System-config-selinux.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 40,
>tab: line 1)
fixed
>0 packages and 1 specfiles checked; 1 errors, 1 warnings.

>rpmlint System-config-selinux-2.0.62-13.fc12.src.rpm
>system-config-selinux.src: W: non-coherent-filename
>System-config-selinux-2.0.62-13.fc12.src.rpm
>system-config-selinux-2.0.62-13.fc12.src.rpm  
The same as above

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.