[Bug 501573] Review Request: ndoutils - Stores data from Nagios in a database

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=501573


Xavier Bachelot <xavier at bachelot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xavier at bachelot.org




--- Comment #7 from Xavier Bachelot <xavier at bachelot.org>  2009-06-09 15:38:00 EDT ---
I cannot sponsor you, but here are a few comments about the spec :
- Source0 needs to be a full URL.
- The beta status of the package should be reflected in the release tag and
thus the version needs to be modified.
 
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages
- Why are you disabling postgres support ?
- Why are you installing files manually ? Upstream is not providing an install
target in the Makefile ?
- The initscript should be in %{_initrddir}.
- There are spurious spaces in the mkdir lines.
- The first 3 %attr in the %files section are unneeded, the perms are already
properly set at install time.
- The package doesn't own %{_sysconfdir}/ndoutils
- You don't need to set the dir perms on the last 3 %attr, this is the standard
perms.
- %postun section is empty.
- Add the version and release in the changelog entry.
- You're missing Requires: for the initscripts and scriptlets are not matching
the guidelines.
 
https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_file_scriptlets


There's probably more than that, but this is a start.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.