[Bug 505046] Review Request: perl-Config-Auto - Magical config file parser
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jun 11 10:51:14 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=505046
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2009-06-11 06:51:13 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1404840
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
ef13c2a01755a1a52fa0669db5c381d4651427fe Config-Auto-0.20.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=11, Tests=39, 1 wallclock secs ( 0.08 usr 0.03 sys + 0.73 cusr 0.11
csys = 0.95 CPU)
+ Package perl-Config-Auto-0.20-1.fc12.noarch =>
Provides: perl(Config::Auto) = 0.20
Requires: perl(Carp) perl(Config::IniFiles) perl(File::Basename)
perl(File::Spec::Functions) perl(strict) perl(vars) perl(warnings)
+ Not a GUI application
Should:
1) Drop following Requires as yum will going to resolve it automatically.
Requires: perl(Config::IniFiles)
Requires: perl(Test::More)
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list