[Bug 505184] Review Request: xorriso - ISO 9660 image manipulation tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505184





--- Comment #6 from Juha Tuomala <tuju at iki.fi>  2009-06-12 12:12:12 EDT ---
(In reply to comment #5)
> rpmlint output:
> xorriso.x86_64: W: devel-file-in-non-devel-package
> /usr/lib64/pkgconfig/xorriso.pc

Removed during %install and also communicated with upstream to remove it, he
agreed.

> xorriso.x86_64: E: zero-length /usr/share/doc/xorriso-0.3.8/CONTRIBUTORS
> 3 packages and 0 specfiles checked; 1 errors, 1 warnings.

> - Drop the CONTRIBUTORS file and add
>  [ -s CONTRIBUTORS ] && exit 1

fixed.

> - Change
>  Release: 1%{?dist}
> to  Release: 1.%{__patchlevel}%{?dist}

fixed.

> NEEDSWORK
> - License is GPLv2 and GPL+ and (LGPLv2+ or MIT), not GPLv2.
> * Most of the files are under GPLv2.
> * cleanup is under GPL license (GPL+)
> * make_isohybrid_mr is LGPLv2+ or MIT.

fixed to: GPLv2 and GPL and LGPLv2+


> - No source URL provided. Source matches upstream.

fixed.

> - Time stamps are not preserved, use
>  make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

fixed.

> MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'.
> NEEDSWORK
> - Add Requires: pkgconfig.

Not needed as file is removed during the install and will
disappear in future releases.

> SHOULD: If the package does not include license text(s) as separate files from
> upstream, the packager should query upstream to include it. NEEDSWORK
> - Not all licenses are included.

Communicated with upstream. What should i do with this, start
hunting those files myself (not preferred) or wait the next
release and fix the spec to include them?

Spec URL: http://tuju.fi/fedora/11/xorriso.spec
SRPM URL: http://tuju.fi/fedora/11/xorriso-0.3.8-2.pl00.fc10.src.rpm
f11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1408600

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.