[Bug 505813] New: Review Request: Ballview

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: Ballview

https://bugzilla.redhat.com/show_bug.cgi?id=505813

           Summary: Review Request: Ballview
           Product: Fedora
           Version: 10
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: nobody at fedoraproject.org
        ReportedBy: mycae at yahoo.com
         QAContact: extras-qa at fedoraproject.org
                CC: notting at redhat.com, fedora-package-review at redhat.com
   Estimated Hours: 0.0
    Classification: Fedora


SPEC URL: http://dhd.selfip.com/427e/ballview-1.spec
SRPM URL: http://dhd.selfip.com/427e/ballview-1.2-1.fc10.src.rpm 

Koji Build:
F10: http://koji.fedoraproject.org/koji/taskinfo?taskID=1410847

RPMLint output:
]$ rpmlint  ../SRPMS/ballview-1.2-1.fc10.src.rpm ../RPMS/i386/ballview-*2-1.*
../RPMS/noarch/ballview-doc-1.2-1.fc10.noarch.rpm 
ballview.i386: E: explicit-lib-dependency libXmu
ballview.i386: W: shared-lib-calls-exit /usr/lib/libVIEW.so.1.2 exit at GLIBC_2.0
ballview-devel.i386: W: no-documentation
ballview-doc.noarch: W: file-not-utf8
/usr/share/doc/ballview/doxygen/latex/classBALL_1_1CreateSpectrumProcessor.tex
ballview-doc.noarch: W: file-not-utf8
/usr/share/doc/ballview/doxygen/latex/classBALL_1_1RotationalEntropyLoss.tex
5 packages and 0 specfiles checked; 1 errors, 4 warnings.

Without the libXmu requires, the build fails at configure time. Not sure what
requires I should use here. As for the UTF-8 errors, I will fix them along with
whatever comments are made here for -2. Sorry about that, limited time to spend
on this and the build takes my poor little machine a long time to complete.

Bugs have been opened upstream :
-regarding the use of the exit() function
http://ball-trac.bioinf.uni-sb.de/ticket/221
-Missing LGPL boilerplate on source files.
http://ball-trac.bioinf.uni-sb.de/ticket/220
-Incorrectly written unit test
http://ball-trac.bioinf.uni-sb.de/ticket/219
-Header file patches
http://ball-trac.bioinf.uni-sb.de/ticket/218


Possible problems:
*The include subdir of the tarball has .iC files, which I have no idea what
they are for. They appear to be C++ like, with heavy use of preprocessor
macros, but why should this be in include? 
*One of the unit tests hangs (on the actual test itself, not the component
being tested, as far as I can tell). I have therefore disabled make test, and
opened an upstream bug.
*I removed smpflag support, as I suspect the makefiles of not being reliable
when run in this fashion (I had a few problems building with -j 2, which were
intermittent, which have not re-occurred since removal of smpflags).
*Enabling GSL and FFTW support modifies the licence to GPLv3. This can be
disabled at configure time to match the closer upstream LGPL. However I wasn't
entirely sure of fedora policy here, so I just enabled them and set the licence
field accordingly.
*Ballview complains about missing python import "BALL" on startup and
subsequently disables in-app python support. Wasn't sure how to fix this at
this stage.

I would appreciate a co-maintainer if possible, as I am not entirely familiar
with QT & SIP, and the package is somewhat large.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.