[Bug 489686] Review Request: armadillo - fast C++ matrix library with interfaces to LAPACK and ATLAS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489686





--- Comment #51 from Conrad Sanderson <conradsand at ieee.org>  2009-06-14 00:54:50 EDT ---
(In reply to comment #46)
> 2. I would add a "-f" (force) flag in the following line:
>  rm examples/Makefile.cmake

ok

> 3. (...) I would suggest (but that is not at all a Fedora 
> requirement) to burry the header files in a specific 
> directory, resulting, after the installation, into:
>  %{_includedir}/armadillo/armadillo
>  %{_includedir}/armadillo/bits
>  %{_includedir}/armadillo/armadillo_itpp
> That way, you would have to add the armadillo directory 
> prefix when you include Armadillo headers. For instance:
> #include <armadillo/bits/Mat_meat.hpp>

The files from the "armadillo_bits" directory are never directly included by
the user (it wouldn't work). Instead, the user includes only one file, i.e.
#include <armadillo>
which then includes everything from "armadillo_bits".

(In reply to comment #50)
> ...
> But, as lapack-devel and blas-devel include only libraries 
> (and not header files), I would exclude the correspondent 
> dependency from the 'Requires:' part.

I see what you're getting at, but I'm not totally clear on this. Users will be
linking their armadillo programs with -larmadillo, which in turn should
automatically pull in the lapack and blas libraries.  However, aren't
"/usr/lib/liblapack.so" and "/usr/lib/libblas.so" required for this to work? 
(they're present in lapack-devel and blas-devel).

> The same way, I would exclude dependency on 'libstdc++-devel'.

Armadillo explicitly needs the header files from "libstdc++-devel", unless we
can assume that a c++ compiler will always be installed ?  (I didn't want to
make a dependency on gcc-c++, as people may possibly want to use another
compiler).

> So, following is a suggestion for the corresponding part in the RPM
> specification file:
> -------------------
> # The header files of %{name} include some Boost header files, delivered within
> # the boost-devel sub-package. However, since there is no dependency on any
> # Boost library (most of Boost is delivered as header files only), the RPM
> # building process does not detect that dependency. That dependency must
> # therefore be added manually.
> Requires:       boost-devel
> -------------------  

ok.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.