[Bug 505957] Review Request: perl-Syntax-Highlight-Perl-Improved - Highlighting of Perl Syntactical Structures

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505957


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-06-15 00:19:14 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1414174
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
f8061cb41dde2d9d028f8a5dc41e7e5390825dc1 
Syntax-Highlight-Perl-Improved-1.01.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
No tests defined for Syntax::Highlight::Perl::Improved extension.
+ Package perl-Syntax-Highlight-Perl-Improved-1.01-1.fc12.noarch =>
Provides: perl(Syntax::Highlight::Perl::Improved)
Requires: perl(Carp) perl(Data::Dumper) perl(base) perl(constant) perl(strict)
perl(vars)
+ Not a GUI application

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.