[Bug 505955] Review Request: perl-Module-Starter-Plugin-CGIApp - Template based module starter for CGI apps

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505955


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Parag AN(पराग) <panemade at gmail.com>  2009-06-15 03:02:26 EDT ---
eview:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1414354
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
e5bab1d5d4fcf419b5b3f193ee8fe59d1688ae2c 
Module-Starter-Plugin-CGIApp-0.10.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=7, Tests=97,  2 wallclock secs ( 0.08 usr  0.01 sys +  1.44 cusr  0.12
csys =  1.65 CPU)
+ Package perl-Module-Starter-Plugin-CGIApp-0.10-1.fc10 =>
Provides: perl(Module::Starter::Plugin::CGIApp) = 0.10
Requires: /usr/bin/perl perl(Carp) perl(English) perl(ExtUtils::Command)
perl(File::Basename) perl(File::Spec) perl(HTML::Template)
perl(Module::Starter) perl(Module::Starter::App) perl(Module::Starter::Simple)
perl(base) perl(strict) perl(warnings)
+ Not a GUI application
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.