[Bug 506006] Review Request: perl-Test-WWW-Mechanize-CGIApp - Test::WWW::Mechanize for CGI::Application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506006


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-06-15 05:39:00 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1414513
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
5caa9fe9ec918ad75657228ae0a41ac0a5efb108  Test-WWW-Mechanize-CGIApp-0.05.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=6, Tests=39,  2 wallclock secs ( 0.06 usr  0.01 sys +  1.29 cusr  0.12
csys =  1.48 CPU)
+ Package perl-Test-WWW-Mechanize-CGIApp-0.05-1.fc12.noarch =>
Provides: perl(Test::WWW::Mechanize::CGIApp) = 0.05
Requires: perl(HTTP::Request::AsCGI) perl(base) perl(strict) perl(warnings)
+ Not a GUI application

When I try to install this package, I saw we need to add 
Requires: perl(CGI::Application)
Requires: perl(Test::WWW::Mechanize)
Requires: perl(Test::More)

yum does not pick it up automatically.
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.