[Bug 505928] Review Request: hdapsd - Protects hard drives by parking head when fall is detected

bugzilla at redhat.com bugzilla at redhat.com
Mon Jun 15 19:58:50 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505928


Steve Traylen <steve at traylen.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |steve at traylen.net




--- Comment #1 from Steve Traylen <steve at traylen.net>  2009-06-15 15:58:49 EDT ---
Hi Thomasz,

I am not able to sponsor you but I can hopefully offer some comments.

There are some rpmlint errors:

$ rpmlint ../RPMS/x86_64/hdapsd-20090401-1.fc11.x86_64.rpm 
hdapsd.x86_64: W: non-conffile-in-etc /etc/event.d/hdapsd
hdapsd.x86_64: W: non-conffile-in-etc /etc/udev/rules.d/99-hdapsd.rules
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

which to me look like they could and should be fixed.

Maybe add a
%doc README AUTHORS ChangeLog ....

these files never do any harm to be included.
 Steve.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list