[Bug 505917] Review Request: libpuzzle - Library to quickly find visually similar images

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505917





--- Comment #3 from Steve Traylen <steve at traylen.net>  2009-06-16 04:20:41 EDT ---
Hi, It builds now.

There some rpmlint errors that need fixing.

$ rpmlint libpuzzle-0.11-1.fc11.x86_64.rpm 
libpuzzle.x86_64: E: standard-dir-owned-by-package /usr/share/man/man3
libpuzzle.x86_64: E: standard-dir-owned-by-package /usr/share/man/man8
libpuzzle.x86_64: E: zero-length /usr/share/doc/libpuzzle-0.11/ChangeLog
libpuzzle.x86_64: E: zero-length /usr/share/doc/libpuzzle-0.11/NEWS

see 

$ rpmlint -I standard-dir-owned-by-package

to get details on the individual messages. In particular for the first one
see the first paragraph of:

https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership

There are few trivial ones as well in the php package.

$ rpmlint php-libpuzzle-0.11-1.fc11.x86_64.rpm 
php-libpuzzle.x86_64: E: zero-length
/usr/share/doc/php-libpuzzle-0.11/EXPERIMENTAL
php-libpuzzle.x86_64: W: file-not-utf8
/usr/share/doc/php-libpuzzle-0.11/similar.php
php-libpuzzle.x86_64: W: non-conffile-in-etc /etc/php.d/libpuzzle.ini

Also  I don't think you need or shoudl have the 
Requires: gd 

since this is picked up automatically anyway. Check for php bits as
well but am less sure. See:

https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.