[Bug 506186] Review Request: perl-p5-Palm - Palm OS utility functions

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506186


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-06-16 06:45:26 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1417345
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
bb5307ff9340add0a78bf4e690adfdeef4707a92  p5-Palm-1.009.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave nothing.
+ Package perl-p5-Palm-1.009-1.fc12.noarch =>
Provides: perl(Palm) = 1.1 perl(Palm::Address) = 1.19 perl(Palm::DateTime) =
1.4 perl(Palm::Datebook) = 1.20 perl(Palm::Mail) = 1.17 perl(Palm::Memo) = 1.13
perl(Palm::PDB) = 1.36 perl(Palm::Raw) = 1.11 perl(Palm::StdAppInfo) = 1.20
perl(Palm::ToDo) = 1.12 perl(Palm::ZirePhoto) = 1.9
Requires: /usr/bin/perl perl(Exporter) perl(POSIX) perl(Palm::Address)
perl(Palm::Datebook) perl(Palm::Mail) perl(Palm::Memo) perl(Palm::PDB)
perl(Palm::Raw) perl(Palm::StdAppInfo) perl(Palm::ToDo) perl(constant)
perl(strict) perl(vars) perl(warnings)
+ Not a GUI application

Should:
1) Consider adding examples directory to %doc

Here perl(Test::More) as requires is not needed as its only used by tests
directory and we are not installing them.
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.