[Bug 506187] Review Request: perl-TheSchwartz - Reliable job queue

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506187


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-06-16 06:58:36 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1417347
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
56df454fa7041220fee2c90f251605ce8dc27357  TheSchwartz-1.07.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=23, Tests=421,  4 wallclock secs ( 0.21 usr  0.07 sys +  3.02 cusr  0.43
csys =  3.73 CPU)
+ Package perl-TheSchwartz-1.07-2.fc12.noarch =>
Provides: perl(TheSchwartz) = 1.07 perl(TheSchwartz::Error)
perl(TheSchwartz::ExitStatus) perl(TheSchwartz::FuncMap) perl(TheSchwartz::Job)
perl(TheSchwartz::JobHandle) perl(TheSchwartz::Worker)
Requires: /usr/bin/perl perl(Carp) perl(DBI)
perl(Data::ObjectDriver::Driver::DBI) perl(Data::ObjectDriver::Errors)
perl(Digest::MD5) perl(Getopt::Long) perl(List::Util) perl(Storable)
perl(TheSchwartz::Error) perl(TheSchwartz::ExitStatus)
perl(TheSchwartz::FuncMap) perl(TheSchwartz::Job) perl(TheSchwartz::JobHandle)
perl(base) perl(constant) perl(fields) perl(strict)
+ Not a GUI application

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.