[Bug 499539] Review Request: saxpath - Simple API for xpath

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499539





--- Comment #10 from Andrew Overholt <overholt at redhat.com>  2009-06-16 16:45:55 EDT ---
(In reply to comment #9)
> overholt, below is the new SPEC/SRPM/POM URLs, have fixed the warnings of
> "wrong-file-end-of-line-encoding" and "mixed-use-of-spaces-and-tabs", please
> review again, thanks.

You still have a trailing tab character on line 6.  Thanks for fixing the other
warning.

Full review below.  Lines beginning with X need to be fixed.

- naming fine
- version and release fine
- licensing fine
- built from source
X ChangeLog entries should be added for your changes
- tags are fine
X rpmlint warning about mixed-use-of-spaces-and-tabs
- no native code to shared libraries, rpath, etc. waived
- not a GUI app
- macros used appropriately
- no locale data so nothing to worry about here
- package contains code
- %files okay
- maven stuff okay

Other than the minor rpmlint warning and the need to add some %changelog
entries, this package is ready to go.  Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.