[Bug 499319] Review Request: tcl-snmptools - TCL extension for SNMP support

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499319





--- Comment #12 from Bryson Lee <bamablee at gmail.com>  2009-06-17 01:02:55 EDT ---
Posted updated spec and SRPM:

http://www.slac.stanford.edu/~blee/tcl-snmptools.spec
http://www.slac.stanford.edu/~blee/tcl-snmptools-1.0-4.fc10.src.rpm

Addressed the following items:

> - Doesn't the version macro at 
>  http://fedoraproject.org/wiki/Packaging/Tcl#arch-specific_packages
> work? Where does it fail?
>

It works when I build locally.  There was a comment in the original specfile I
used as a template to the effect that determining the TCL version
programmatically failed on the Fedora build system because tclsh was not
installed by default.  I've removed the comment and updated to the documented
version macro on the assumption that it's working now.

> - Have you tried the configure argument --libdir=%{tcl_sitearch} to change the
> default install location?
> 
> - Do you really need to specify --with-tcl=%{_libdir}? OK, on multiarch arches
> with both 32- and 64-bit versions installed you might get into trouble if
> configure picks up the wrong version. No hurt having this if you think it's
> necessary.
> 

--libdir=%{tcl_sitearch} appears to work, including on my multiarch machine.

> this is really not necessary, since CMU is compatible with GPL and License:
> GPLv3+ is enough.
>

> MUST: The License field in the package spec file must match the actual license.
> NEEDSFIX
> - See comment above, license tag should be just GPLv3+.

License tag updated to GPLv3+ only.

> 
> MUST: Optflags are used and time stamps preserved. NEEDSFIX
> - Even though the files that are installed are generated, it's always nice to
> preserve time stamps in install phase. Use INSTALL="install -p" as argument to
> make install.
>

Added INSTALL="install -p" as suggested.

> just put
>  %{tcl_sitearch}/%{realname}%{version}/
> as this will own the directory and everything in it.
>

Done.

> - Add AUTHORS. BUGS and TODO should otherwise be included, but now they just
> contain instructions to grep the code.

Done.

Thanks,

Bryson

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.