[Bug 506056] Review Request: zikula-module-scribite - The scribite! module for Zikula allows integration of various text editors

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506056





--- Comment #1 from Toshio Ernie Kuratomi <a.badger at gmail.com>  2009-06-17 20:13:55 EDT ---
A couple easy ones that I found before the licensing audit:

* Summary does not need to repeat the module name.  Maybe something like::
  Integration of several JavaScript text editors with Zikula
* Includes JavaScript libraries.  Until JavaScript Guidelines are approved,
this is okay.  Once they are we'll have to package the JavaScript libraries
separately and then have this package link to them (perhaps with a literal
symlink).

Here's the big one:
* Licensing violations :-(
  Most of the files are a mix of GPLv2+, LGPLv2+ (Might have some v2 only but I
haven't checked yet), and BSD.  This places the module as a whole under the
GPLv2+ (or v2 if there's any v2 only code).  So far this is fine.  But we do
have some GPL incompatible licensed code as well that we have to deal with,
either by getting rid of it (some things aren't necessary) or rewriting or
relicensing:
(Note scribite/modules/scribite/pndocs/fckeditor_license.txt is licensed under
MPLv1.1+ or GPLv2+ or LGPLv2+.  This is fine)

Creative Commons Licenses: No CC licenses are GPL compatible:
This one could be a problem:
* scribite/modules/scribite/pnjavascript/window.js: Some of the file is
MIT-like.  But about three-quarters of the way through the file we have:
Licensed under the Creative Commons Attribution 2.5 License -
http://creativecommons.org/licenses/by/2.5/

* scribite/javascript/scribite_editors/xinha/skins/inditreuse/README:This work
is licensed under the Creative Commons Attribution-ShareAlike License.
* scribite/javascript/scribite_editors/xinha/skins/titan/README:This work is
licensed under the Creative Commons Attribution-ShareAlike License.
*
scribite/javascript/scribite_editors/xinha/plugins/CharacterMap/character-map.js:
license : "Creative Commons Attribution-ShareAlike License"
*
scribite/javascript/scribite_editors/xinha/plugins/HtmlEntities/html-entities.js:
license : "Creative Commons Attribution-ShareAlike License"
* scribite/javascript/scribite_editors/xinha/plugins/ListType/list-type.js:
license : "Creative Commons Attribution-ShareAlike License"

PHP License:
PHP License v3 is definitely GPL incompatible.  I do not know if PHP License
v2.02 is also.

*
scribite/javascript/scribite_editors/xinha/plugins/ImageManager/Classes/GD.php:
This is licensed under the php-2.02 license.
*
scribite/javascript/scribite_editors/xinha/plugins/ImageManager/Classes/NetPBM.php:
This is licensed under the php-2.02 license.
*
scribite/javascript/scribite_editors/xinha/plugins/ImageManager/Classes/IM.php:
This is licensed under the php-2.02 license.
scribite/javascript/scribite_editors/xinha/plugins/ImageManager/Classes/Transform.php


MPL:
Unless the MPL lists other licenses that the work can be released under
(ie,dual licensed with GPL) this is incompatible with the GPL

scribite/javascript/scribite_editors/tiny_mce/filemanager/connectors/php/Commands/helpers/header.cgi:
MPLv1.1
scribite/javascript/scribite_editors/tiny_mce/filemanager/connectors/php/Commands/helpers/progress.cgi:
MPLv1.1
scribite/javascript/scribite_editors/tiny_mce/filemanager/connectors/php/Commands/helpers/upload.cgi:
MPLv1.1

itbegins thinks that with the exception of
scribite/modules/scribite/pnjavascript/window.js, all of these files are
optional and we could remove them when we package.  window.js might be optional
as well, but he's not sure.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.