[Bug 506670] Review Request: perl-CGI-Application-Plugin-ErrorPage - Simple error page plugin for CGI::Application
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jun 18 10:57:18 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=506670
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2009-06-18 06:57:17 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1422631
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
4b72250fa6764effbc2e8d9c0d212f65306478fe
CGI-Application-Plugin-ErrorPage-1.20.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=2, 0 wallclock secs ( 0.04 usr 0.01 sys + 0.14 cusr 0.02
csys = 0.21 CPU)
+ Package perl-CGI-Application-Plugin-ErrorPage-1.20-1.fc12.noarch=>
Provides: perl(CGI::Application::Plugin::ErrorPage) = 1.20
Requires: perl(Params::Validate) perl(base) perl(strict) perl(vars)
perl(warnings)
+ Not a GUI application
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list