[Bug 506450] Package Review: twitter-glib - A library wrapping the Twitter RESTful API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506450





--- Comment #2 from Peter Robinson <pbrobinson at gmail.com>  2009-06-18 07:00:47 EDT ---
(In reply to comment #1)
> MUST:
> twitter-glib.src: W: invalid-license LGPLv2.1+
> Should be License: LGPLv2

I put that because from the README file:
Twitter-GLib is released under the terms of the GNU Lesser General
Public License version 2.1 or, at your option, any later version.

> Cosmetic:
> 
> URL: http://live.gnome.org/TwitterGlib    
> makes more sense I think.

Will do, I never found that one previously :)

> BuildRequires: gtk-doc
> is not really necessary , the tarball has that already built.
> 
> The package has a testsuite that doesn't seem to do anything network related.
> You could add
> %check
> make check
> 
> With the license change this package is APPROVED.
> 
> I am not sure why this is a blocker for the rest review...  

It shouldn't have been, but I was looking at hundreds of deps/bz bugs etc
yesterday so it was probably a brain fart.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.