[Bug 506712] Package Review: libccss - A simple api for CSS Stylesheets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506712


Yanko Kaneti <yaneti at declera.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |yaneti at declera.com
         AssignedTo|nobody at fedoraproject.org    |yaneti at declera.com
               Flag|                            |fedora-review+




--- Comment #1 from Yanko Kaneti <yaneti at declera.com>  2009-06-18 12:23:14 EDT ---
This time I looked through the source files and they all have the "or (at your
option) any later version" variety, which in my understanding makes the package
LGPLv2+ .

URL: http://cgit.freedesktop.org/ccss/ 
or
URL: http://people.freedesktop.org/~robsta/libccss/

BuildRequires: gtk-doc
is not really necessary, the tarball has the docs already built.

The last paragraph of the description seems out of place (everything after the
bullet points) . Perhaps just remove it.

You could add --disable-examples to spare few cycles.

There is a TODO file that looks to be maintained.

You could 
%{_includedir}/libccss-1
and be done with it. If the package is not split on cairo/gtk etc. there is
hardly a point in listing everything.


Other than the license, all minor concerns. I believe you'll fix that prior to
import. APPROVED.


Again as with rest some head scratching on weather it should be called libccss
or ccss , but I like the idea of sticking with the tarball name best. And its
just a library.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.