[Bug 506578] Review Request: rtkit - Realtime Policy and Watchdog Daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506578





--- Comment #5 from Lennart Poettering <lpoetter at redhat.com>  2009-06-18 12:57:06 EDT ---
(In reply to comment #3)
> packaging guidelines: should follow 
>   https://fedoraproject.org/wiki/Packaging:UsersAndGroups for adding
> users/groups
>   - add a home dir, maybe
>   - not sure the getent foo is really essential, but you need to make sure that
> %pre does exit with 0 even if the user/group are already there

We use /proc as homedir (i.e. -c /proc). This is the only thing that remotely
makes sense, given that rtkit chroot()s into /proc after starting up. 

The code in the spec file does almost exactly what the user/groups
documentation you linked suggests, except that we use groupadd -f instead of
the seperate getent check when creating the group, and for the user we check
the availability with 'id' insted of getent.

I have however added a final "exit 0" now.

> license: ok
> license field: ok, not sure if you need to add BSD there for the included
> sources, probably yes, with a comment explaining what it applies to, see
> https://fedoraproject.org/wiki/Packaging/LicensingGuidelines

Fixed.

> license file: ok
> spec language: ok
> spec legible: yes
> upstream sources: please put the tarball where the source url says

Done.

> buildable: ok
> excludearch: ok
> build deps: ok
> locale handling: n/a
> shared libs: n/a
> relocatable: n/a
> directory ownership: ok
> 
> [...to be continued...]  

I have now updated the spec file in-place.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.