[Bug 505356] Review Request: php-PHPMailer - PHP email transport class with a lot of features

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505356





--- Comment #1 from Remi Collet <fedora at famillecollet.com>  2009-06-18 14:21:24 EDT ---
I don't think installing class directly under /usr/share/php is a good idea
(if lot of package does this, we are going to create a lot of conflicts)

Should use sed rather than ed

sed -i -e ...

I think a better solution is to install in /usr/share/php/PHPMailer and Set
PluginDir in class (quite strange than SetLanguage doesn't use it)

Tagging lang file seems usefull, something like 

# Lang
for i in %{buildroot}%{_datadir}/path/to/language/*.php
do
  lang=$(basename $i)
  echo "%lang(${lang:15:2}) %{_datadir}/path/to/language/${lang}"
done >%{name}.lang

And 
%file -f %{name}.lang

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.