[Bug 461393] Review Request: congruity - Application to program Logitech® Harmony® universal remote controls

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461393


leigh scott <leigh123linux at googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




--- Comment #19 from leigh scott <leigh123linux at googlemail.com>  2009-06-18 15:58:01 EDT ---
* source files match upstream: OK.
b41601c3a13d889422b707f854b7a23b652a48b8
congruity-11.tar.bz2
* package meets naming and versioning guidelines. OK.
* specfile is properly named, is cleanly written and uses macros consistently.
OK.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license. OK
* license is open source-compatible. OK.
* license text included in package. OK.
* latest version is being packaged. OK.
* BuildRequires are proper . OK.
* %clean is present. OK.
* Desktop file is properly installed with desktop-file-install. OK.
* package builds in Koji dist-f11 OK.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1423291
* package installs and uninstalls properly. OK.
* rpmlint is silent. OK.
rpmlint -vi congruity-11-2.fc11.src.rpm
congruity.src: I: checking
1 packages and 0 specfiles checked; 0 errors, 0 warnings

rpmlint -vi congruity-11-2.fc11.noarch.rpm
congruity.noarch: I: checking
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
* final provides and requires are sane:
congruity = 11-1.fc11

/bin/sh  
/bin/sh  
/usr/bin/env  
libconcord-python >= 0.20
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
wxPython >= 2.8

* owns the directories it creates. OK.
* doesn't own any directories it shouldn't. OK.
* no duplicates in %files. OK.
* %check is not present; no test suite.  I installed and ran the program, but I 
   have neither the necessary remote nor a programming file for it.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* file permissions are appropriate. OK 
* scriptlets present and correct. OK



Note:

The License includes this, I'm not sure if you need to add it the License tag

Licensing for remote.png:
CC-BY-SA-2.5
Downloaded from the URL below, resized, and made transparent:
http://commons.wikimedia.org/wiki/Image:Harmony670.jpg


Recommend:

You have set the file permissions, this isn't needed.

%defattr(0644,root,root,0755)
%doc Changelog COPYING LICENSE.txt README.txt
%attr(0755, root, root) %{_bindir}/*

should be

%defattr(-,root,root,-)
%doc Changelog COPYING LICENSE.txt README.txt
%{_bindir}/*

I have tested this

rpm -qav --list  congruity 
-rwxr-xr-x    1 root    root                    61266 Jun 18 20:33
/usr/bin/congruity
-rw-r--r--    1 root    root                      117 Jun 18 20:33
/usr/share/applications/congruity.desktop
drwxr-xr-x    2 root    root                        0 Jun 18 20:33
/usr/share/congruity
-rw-r--r--    1 root    root                     2192 Jun 18 20:33
/usr/share/congruity/icon-complete.png
-rw-r--r--    1 root    root                     1960 Jun 18 20:33
/usr/share/congruity/icon-failed.png
-rw-r--r--    1 root    root                     1956 Jun 18 20:33
/usr/share/congruity/icon-in-progress.png
-rw-r--r--    1 root    root                     1400 Jun 18 20:33
/usr/share/congruity/icon-unstarted.png
-rw-r--r--    1 root    root                   136801 Jun 18 20:33
/usr/share/congruity/remote.png
drwxr-xr-x    2 root    root                        0 Jun 18 20:33
/usr/share/doc/congruity-11
-rw-r--r--    1 root    root                    35147 Jun 18 04:54
/usr/share/doc/congruity-11/COPYING
-rw-r--r--    1 root    root                     5840 Jun 18 04:54
/usr/share/doc/congruity-11/Changelog
-rw-r--r--    1 root    root                     1281 Jun 18 04:54
/usr/share/doc/congruity-11/LICENSE.txt
-rw-r--r--    1 root    root                     5840 Jun 18 04:54
/usr/share/doc/congruity-11/README.txt
-rw-r--r--    1 root    root                      623 Jun 18 20:33
/usr/share/man/man1/congruity.1.gz




***Package Approved***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.