[Bug 506669] Review Request: perl-CGI-Application-Plugin-DBH - Easy DBI access from CGI::Application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506669


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-06-19 03:13:21 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1424382
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
41d4b4587ae59e7b5518a76583172c501aa621ab 
CGI-Application-Plugin-DBH-4.00.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=5, Tests=29,  1 wallclock secs ( 0.05 usr  0.02 sys +  0.53 cusr  0.08
csys =  0.68 CPU)
+ Package perl-CGI-Application-Plugin-DBH-4.00-1.fc12.noarch =>
Provides: perl(CGI::Application::Plugin::DBH) = 4.00
Requires: perl(Carp) perl(Exporter) perl(strict) perl(vars)
+ Not a GUI application

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.