[Bug 503202] Review Request: blueproximity - A tool that locks/unlocks your screen when your bluetooth devices gets away/near from your computer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503202


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #5 from Parag AN(पराग) <panemade at gmail.com>  2009-06-19 06:05:18 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1424595
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
2238a853a7f37b19160867b77bdb0a2df43449b9  blueproximity-1.2.5.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ desktop file installed correctly.
+ GUI App

Should:
1) blueproximity.1 is man page file. So it should be installed as man page not
just documentation.
use following patch
--------------------------------------------------------------
--- blueproximity.spec 2009-06-18 22:58:54.000000000 +0530
+++ blueproximity-new.spec 2009-06-19 15:31:42.000000000 +0530
@@ -34,11 +34,13 @@
 install -d %{buildroot}%{_bindir}
 install -d %{buildroot}%{_datadir}/pixmaps/
 install -d %{buildroot}%{_datadir}/%{name}/pixmaps/
+install -d %{buildroot}%{_mandir}/man1/

 # Install Files
 install -p -m 0755 start_proximity.sh %{buildroot}%{_bindir}/%{name}
 install -p -m 0755 proximity.py %{buildroot}%{_datadir}/%{name}/
 install -p -m 0644 proximity.glade %{buildroot}%{_datadir}/%{name}/
+install -p -m 0644 doc/blueproximity.1 %{buildroot}%{_mandir}/man1/

 # Install Languages
 for i in $(ls LANG/); do
@@ -67,9 +69,10 @@

 %files -f %{name}.lang
 %defattr(-,root,root,-)
-%doc ChangeLog COPYING README doc/
+%doc ChangeLog COPYING README doc/manual*
 %{_datadir}/%{name}
 %{_bindir}/%{name}
+%{_mandir}/man1/blueproximity*
 %{_datadir}/applications/%{name}.desktop
 %{_datadir}/pixmaps/%{name}_base.svg
------------------------------------------------------------------------

Make sure you fix this thing and then import this package to cvs.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.