[Bug 499319] Review Request: tcl-snmptools - TCL extension for SNMP support

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499319





--- Comment #14 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-06-19 15:11:37 EDT ---
rpmlint output:
tcl-snmptools.x86_64: W: incoherent-version-in-changelog 1.0-4 ['1.0-5.fc11',
'1.0-5']
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

- You are missing the latest version from the changelog.

- The line
 install -d %{buildroot}%{tcl_sitearch}
should be dropped since it doesn't do anything (it's after the install
command).

- You seem to be missing BR: tcl, since
Mock Version: 0.9.16
ENTER do(['bash', '--login', '-c', 'rpmbuild -bs --target x86_64 --nodeps
builddir/build/SPECS/tcl-snmptools.spec'], False,
'/var/mock/fedora-11-x86_64/root/', None, 0, True, 0, 500, 494, None,
logger=<mock.trace_decorator.getLog object at 0xc86c50>)
Executing command: ['bash', '--login', '-c', 'rpmbuild -bs --target x86_64
--nodeps builddir/build/SPECS/tcl-snmptools.spec']
sh: tclsh: command not found
sh: tclsh: command not found
sh: tclsh: command not found

- A comment on style: I suggest using trailing slashes for directories in the
%files section:
 %{tcl_sitearch}/%{realname}%{version}/
instead of
 %{tcl_sitearch}/%{realname}%{version}/


Apart from these minor issues I think the package is good to go.

Do you have other submissions? Have you done informal reviews of other people's
packages? Before I sponsor you, you need to show me you're worth it :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.