[Bug 504424] Review Request: ruby-json - A JSON implementation in Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504424





--- Comment #3 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-06-20 13:15:09 EDT ---
Some notes:

* native ruby module vs rubygem
  - As json rubygem is available, would you consider to use
    json rubygem to package rpm instead of using native tarball?
    ref:
   
https://fedoraproject.org/wiki/Packaging/Ruby#Packaging_for_Gem_and_non-Gem_use


* License
  - Should be "Ruby or GPLv2"

* BR
  - You should use "BR: rubygem(rake)" instead of "BR: rubygem-rake"
    like perl. Ref:
    https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides

! Requires
  ! json/editor.rb requires ruby(gtk2). Should "ruby(gtk2)" be added as
    the Requires of this package or should this script be separated into
    a subpackage?

* Stripping binaries
  * json/ext/*.so should not be stripped to create debuginfo rpm
    correctly

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.