[Bug 507030] Review Request: pymunk - Python wrapper for the chipmunk 2D physics engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507030





--- Comment #2 from Robert Spanton <rspanton at zepler.net>  2009-06-21 11:18:00 EDT ---
Cheers Jussi,

I've done the changes you mention.  There are a few things I'd like to query:

 - I can't find anything about patch naming in the packaging guidelines.

 - I think I do need python-setuptools as a BuildRequires, as setup.py requires
   it and it's not listed in the exception list:
     https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2
   Building without python-setuptools results in fail:
     http://koji.fedoraproject.org/koji/getfile?taskID=1427723&name=build.log

 - Why did you require me to make the change to %files, as the RPM ends up
owning exactly the same files and directories?

Updated spec: http://users.ecs.soton.ac.uk/rds/rpm/pymunk/pymunk.spec
New SRPM:
http://users.ecs.soton.ac.uk/rds/rpm/pymunk/pymunk-0.8.2-2.fc11.src.rpm

Thanks,

Rob

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.