[Bug 507030] Review Request: pymunk - Python wrapper for the chipmunk 2D physics engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507030





--- Comment #6 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-06-21 13:10:42 EDT ---
- You have to BuildRequires: chipmunk to get the filename of the library:

++ ls '/usr/lib64/libchipmunk.so.*'
++ head -n 1
ls: cannot access /usr/lib64/libchipmunk.so.*: No such file or directory

(Don't BR: chipmunk-devel, since you only want the versioned so file. Make a
comment about this.)

- Remove the .so and .dll file from pymunk.egg-info/SOURCES.txt with the
sharedlib patch and remove the files in %setup. Then you can drop
 # We use chipmunk's shared library, so get rid of the inbuilt version 
 rm -f $RPM_BUILD_ROOT/%{python_sitelib}/pymunk/{chipmunk.dll,libchipmunk.so}
from %install altogether, since nothing is installed.

- If you want, you can use "python" instead of "%{__python}". (%{__python}
evaluates to /usr/bin/python)

- I'm not quite sure if there is a need to have a separate -doc package. After
all:
 $ du -hc *
 56K pymunk-0.8.2-3.fc11.noarch.rpm
 72K pymunk-doc-0.8.2-3.fc11.noarch.rpm
 128K total
IMHO 72k is not worthwhile to separate from the main package.

- Examples contain pymunx which is under GPL+ license, this needs to be
reflected in the license tag of the package this file is in. If you want to go
with a separate -doc package, its license should be "MIT and GPL+", with the
main package having MIT license. Otherwise this must be the license of the main
package.


Once you have fixed these I will do the full review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.