[Bug 506366] Review Request: bouncycastle-tsp - TSP libraries for Bouncy Castle

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506366


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-06-21 14:07:59 EDT ---
Well,

* Misc cosmetic issue
------------------------------------------------
BuildRequires:    bouncycastle == %{version}
Requires:       %{name} = %{version}-%{release}
------------------------------------------------
  - Choose "==" or "=" (I think using "=" instead
    of "==" is more common)

! BR/Requires
  - bouncycastle-mail already has "R: bouncycastle = 1.43" and
    "R/BR: bouncycastle = 1.43" is redundant (however
    I won't oppose to write this explicitly) 

No review blockers
-----------------------------------------------------------
  This package (bouncycastle-tsp) is APPROVED by mtasaka
-----------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.