[Bug 506755] Review Request: tmux - a terminal multiplexer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506755


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |jussi.lehtola at iki.fi
               Flag|                            |fedora-review?




--- Comment #11 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-06-22 00:24:32 EDT ---
The package is not using the Fedora optimization flags (available through
%{optflags} or $RPM_OPT_FLAGS). You need to patch the makefile to get these
into use. Keep the -D and -I and the -std switches, remove everything else (as
the -W switches). You don't need to touch the libs. 

- Add LDFLAGS="$RPM_OPT_FLAGS" to the end of the make command to use the
optimization flags in the linking process too (if the object files have been
compiled e.g. with -fPIC then linking will fail without it).

- Instead of
 examples/*
I'd ship
 examples/
since this is a bit clearer.

- Add TODO to %doc.


I can sponsor you, if you first show me that you know the guidelines. To do
that you need to read the Packaging and the Review Guidelines and to
demonstrate you understand them by making at least one another submission and
do a couple of informal reviews of other people's packages (you'll be able to
do formal ones once I have sponsored you).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.