[Bug 507083] Review Request: poco - C++ class libraries for network-centric applications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507083





--- Comment #2 from Peter Lemenkov <lemenkov at gmail.com>  2009-06-22 07:01:17 EDT ---
Notes:

* Current naming scheme looks unclear at least for me. Why not to split
packages into %{name}-MySQL, %{name}-ODBC and %{name}-ZIP instead of
%{name}-extra.

* I don't fully understand why we need specific %{name}-debug package. We
already have %{name}-debuginfo. In any case I think %{name}-debug should be
splitted into %{name}-debug and %{name}-extra-debug packages (in conformance
with main two packages).

However, I don't insist you to fully satisfy these two requests, but you should
comment them.

* "BuildRequires: /usr/bin/perl" - why not to use "BuildRequires: perl" ?

Other things looks sane. Here is a koji scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=1429077

* rpmlint is almost silent (two warnings may be ignored):

[petro at Workplace Desktop]$ rpmlint poco-*
poco-debug.i586: W: no-documentation
poco-extra.i586: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 2 warnings.
[petro at Workplace Desktop]$

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.