[Bug 506755] Review Request: tmux - a terminal multiplexer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506755





--- Comment #16 from Chess Griffin <chess at chessgriffin.com>  2009-06-23 09:35:55 EDT ---
(In reply to comment #15)
> - Now there's  -iquote. twice in the build flags: it's already added in the
> INCDIRS variable where you replaced -I- to -iquote. , but you have added
> another one in the Linux section after -icompat.
> 
> - I wouldn't use a patch for the iquote issue, I'd just use a sed oneliner in
> %setup which does the same thing:
>  sed -i "s| -I- | -iquote. |g" GNUMakefile
> That or I'd merge the iquote thing with the optflags patch. Anyway, this is up
> to you. To me unnecessary patch files are just unnecessary trouble if they
> aren't needed for very long (this should be fixed in the next upstream release,
> right?).

Done via sed invocation.

> 
> MUST: The License field in the package spec file must match the actual license.
> NEEDSWORK
> - License is ISC and BSD instead of plain BSD, see
> http://fedoraproject.org/wiki/Licensing.
> * Most of the files are licensed under ISC
> * Some of the files in compat/ are under the 2-clause and 3-clause BSD licenses
> => resulting license is ISC and BSD.
> (You can use Debian's licensecheck.pl as a first step to audit the licenses.)

Ah, thanks for the heads up on that nifty tool.  :-)  I have modified the
license field.

Updated Spec URL:
http://chessgriffin.com/files/pkgs/fedora/tmux/tmux.spec

Updated SRPM URL:
http://chessgriffin.com/files/pkgs/fedora/tmux/tmux-0.8-5.fc11.src.rpm

Builds cleanly in mock and koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1431851

> 
> 
> **
> 
> So, apart from the license issue this package is good to go. I won't give you
> an approval yet, I want to see some more action on your part first.  

Understood, thanks again for the review and helpful suggestions.  This has been
a big help to me in understanding some of the Fedora packaging nuances.

Cheers!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.