[Bug 507631] Review Request: rubygem-rubyzip - Ruby module for reading and writing zip files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507631





--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-06-23 13:58:44 EDT ---
Some notes for 0.9.1-1:

* %define -> %global
  - Now Fedora suggests to use %global instead of %define.
    ref:
    https://fedoraproject.org/wiki/Packaging/Ruby#Pure_Ruby_packages
    https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define

* License
  - When it is written as "is distributed under the same license as ruby",
    the license tag should be "GPLv2 or Ruby".

* ruby(abi) Requires
  - All ruby related packages must have "Requires: ruby(abi) = 1.8".
    And for consistency I always recommend to also add
    "BuildRequires: ruby(abi) = 1.8".
    https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines

* %check
  - As this gem file contains test/ directory, please add %check
    stage and execute some tests.
    ( And for this case, I guess expanding gem file under %_builddir
      at %prep is preferred, ref:
      https://fedoraproject.org/wiki/PackagingDrafts/Gem_expand_stage_change
      also see:
     
http://mtasaka.fedorapeople.org/Review_request/rubygem-mocha/rubygem-mocha.spec
    )

* %files
  - As you already defined %geminstdir, please use it also on %files
  - %defattr must be set before writing %doc entry.
  - The directory %geminstdir itself is not owned by this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.