[Bug 507761] Review Request: rubygem-coderay - CodeRay is a fast syntax highlighter engine for many languages

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507761





--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-06-24 04:02:38 EDT ---
For 0.8.312-1:

* %define -> %global
  - We now recommend to use %global instead of %global:
   
https://fedoraproject.org/wiki/Packaging/Ruby#Build_Architecture_and_File_Placement
    https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define

* License
  - From lib/term/ansicolor.rb, the license tag should be
    "GPLv2"

* Moving some document files
  - Would you explain why you want to move README or so from %geminstdir
    to %gemdir/doc ?
    Note that $ gem contents coderay expects that those (README or so) files
    are under %geminstdir.

* %files
  - As you already defined %geminstdir, please use it also in %files
    instead of using %{gemdir}/gems/%{gemname}-%{version}/

! Summary
----------------------------------------------------------------
I try to make CodeRay easy to use and intuitive, ....
----------------------------------------------------------------
  - It is ambiguous what "I" mean here...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.