[Bug 504521] Review Request: SevenZip - Java SDK for LZMA

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504521


Rakesh Pandit <rpandit at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #2 from Rakesh Pandit <rpandit at redhat.com>  2009-06-24 06:30:26 EDT ---
package naming -- done
api-subpackage -- done

[rakesh at dhcp7-204 SevenZip-4.65-1.fc11.x86_64]$ tree
.
`-- usr
    |-- lib64
    |   `-- gcj
    |       `-- SevenZip
    |           |-- SevenZip-4.65.jar.db
    |           `-- SevenZip-4.65.jar.so
    `-- share
        |-- doc
        |   `-- SevenZip-4.65
        |       |-- 7zFormat.txt
        |       |-- Methods.txt
        |       |-- history.txt
        |       `-- lzma.txt
        `-- java
            |-- SevenZip-4.65.jar
            `-- SevenZip.jar -> SevenZip-4.65.jar

8 directories, 8 files

Symlink between project name and commonly used jar file name done
jar files going to %{_javadir} - done
package naming - fails

I am confused about wether SevenZip would be right name for this packages ..
will confirm in some time.

spec file language -- sane
spec file -  legible


[rakesh at dhcp7-204 SPECS]$ md5sum lzma465.tar.bz2 
29d5ffd03a5a3e51aef6a74e9eafb759  lzma465.tar.bz2

[rakesh at dhcp7-204 SPECS]$ md5sum SevenZip-4.65-1.fc11.src/lzma465.tar.bz2 
29d5ffd03a5a3e51aef6a74e9eafb759  SevenZip-4.65-1.fc11.src/lzma465.tar.bz2

md5sum matches -- done
Compiles -- successfully

Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1433244

rpmlint output - mentioned
buildrequires - fine
%files - fine
-doc package - fine

Summary: naming .. I am in doubt will confirm in some time.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.