[Bug 507695] Review Request: python-sqlalchemy0.5 - Modular and flexible ORM library for python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507695





--- Comment #4 from Parag AN(पराग) <panemade at gmail.com>  2009-06-25 06:05:37 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1432964
+ source files match upstream url
0a4f50b690ae946c3188614eeea6f1e5f02681d9  SQLAlchemy-0.5.3.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

I don't get why all .py* files installed under
/usr/lib/python2.6/site-packages/SQLAlchemy-0.5.3-py2.6.egg ?

Why rpmlint is complaining script-without-shebang error with this package
whereas I don't see such rpmlint messages in rawhide package?

why following is added to SPEC ?
BuildRequires:  python-sqlite2

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.