[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507660





--- Comment #3 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-06-26 06:07:14 EDT ---
- Don't call libtool manually. Remove the last three lines in %install, add
instead BuildRequires: automake and 
 sed -i "s|noinst_|bin_|g" Makefile.am
 automake
to %setup, this will make the build process install xyconv to %{_bindir}.

- Use SMP make flags. Change 
 make
to
 make %{?_smp_mflags}

- Change
 %{_bindir}/*
to
 %{_bindir}/xyconv
and
 %{_includedir}/*
to
 %{_includedir}/xylib/
(no sense in using wildcards in these cases)

- The attributes
 %defattr(-,root,root)
should be
 %defattr(-,root,root,-)


SHOULD: Use a more recommended version of the BuildRoot tag
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.