[Bug 508239] Review Request: perl-Hash-Merge - Merges arbitrary deep hashes into a single hash

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508239


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-06-26 06:40:08 EDT ---
+ is ok
- is Need work

Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1436825

- rpmlint is NOT silent for RPM.
perl-Hash-Merge.noarch: E: non-standard-executable-perm
/usr/lib/perl5/vendor_perl/5.10.0/Hash/Merge.pm 0555
perl-Hash-Merge.noarch: E: script-without-shebang
/usr/lib/perl5/vendor_perl/5.10.0/Hash/Merge.pm
==> This need to be fixed.

+ source files match upstream url
23c6a4c3b1f620e47c34c9c9afb962e71195f955  Hash-Merge-0.11.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ make test gave
All tests successful.
Files=1, Tests=45,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.04 cusr  0.00
csys =  0.08 CPU)
+ Package perl-Hash-Merge-0.11-1.fc12.noarch =>
Provides: perl(Hash::Merge) = 0.11
Requires: perl(Carp) perl(base) perl(strict) perl(vars) perl(warnings)
+ Not a GUI application

Suggestions:
1) This package should own /usr/lib/perl5/vendor_perl/5.10.0/Hash
please correct this before cvs import.

2) you missed to add to spec
chmod -R u+w $RPM_BUILD_ROOT/*

3) fix rpmlint output.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.