[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes

bugzilla at redhat.com bugzilla at redhat.com
Fri Jun 26 13:34:21 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507703





--- Comment #2 from Lubomir Rintel <lkundrak at v3.sk>  2009-06-26 09:34:20 EDT ---
1.) Please remove Require: perl(Test::More) dependency, the runtime does not
depend on the testing framework.  

2.) Licensing

Proc/Simple.pm contains this:
# This program is free software, you can redistribute it and/or 
# modify it under the same terms as Perl itself.

Neither README nor POD documentation contains it -- please ask upstream to
include the licensing conditions there.

* rpmlint is quiet
* name is well according to the guidelines
* source matches upstream
* clean and legible SPEC file, American English
* runs testsuite
* builds file in mock
* filelists, documentation ok

Needs work:
- sane provides/requires
- license

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list