[Bug 506581] Review Request: xscope - X Window Protocol Viewer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506581





--- Comment #2 from Yanko Kaneti <yaneti at declera.com>  2009-06-27 06:41:07 EDT ---
(In reply to comment #1)
> I've reviewed the package and it looks quite good. There are only minor TODOs:
> - clarification about the license (I've sent a mail to fedora-legal.)
> * License: TODO
> - Although the meaning of the license seems to match the BSD license, I'm not
> 100% sure its a real BSD license since the wording is different. Just to
> confirm I've asked on the fedora-legal list for confirmation.

Thanks. I've only looked cursory on the licence because frankly licenses make
me queasy. If its not really an acceptable BSD like license then so be it.


> - description formatting
> * %description: TODO (minor)
> - I would reformat the last sentence in the %description section to use up the
> available space of 80 charaters.

done that


> - functional test
> * functional test: TODO
> - running it on the same machine as the X server did not work well:
>   - started "xscope -v1"
>   - started "DISPLAY=:1 gedit" in another console
>   - xscope displays some X11 protocol communication
>   - but gedit doesn't start up completly, X server + xscope + gedit hangs, it
> is necessary to kill xscope by logging in via ssh...
> - probably it is just wrong usage - any hints welcome ;-)

Indeed the lockup you describe happens here too. In fact every time when the
output of xscope itself is running over a terminal on the same server. Don't
really know what to make of it. :/ . The program itslef is in a half baked
state, and I am not sure it even understands the whole range of todays X server
traffic but at least I've managed to succesfully use the package by redirecting
the output to file or running vie another machine.  It was all an attempt to
debug some X slownes over ssh links. I've got the needed capture, don't know
enough of X to say if its useful or not.


> - package builds correctly in koji for F12 and F11, but failed for F10

I've added a patch to lower the xorg-macros requirement a bit, I don't think it
has any detrimental effect on the F10 build. This fixes the build on F10.



* Sun Jun 27 2009 Yanko Kaneti <yaneti at declera.com> 1.1-2.gitfccbbd6
- Implement review feedback
- Patch to build on Fedora 10

SPEC: http://www.declera.com/~yaneti/xscope/xscope.spec
SRPM:
http://www.declera.com/~yaneti/xscope/xscope-1.1-2.gitfccbbd6.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.