[Bug 507110] Review Request: openal-soft - OpenAL-Soft lib

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507110





--- Comment #6 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-06-27 14:11:32 EDT ---
Some notes:

* License tag
  - For this package license tag should be "LGPLv2+".

* pkgconfig .pc file
  - openal.pc (note: see below) contains:
---------------------------------------------------
     3  libdir=${exec_prefix}//usr/lib
---------------------------------------------------
    (on i586), which is apparently wrong.

* Conflict
  - Fedora strongly recommends _not_ to use Conflicts: on
    such file namespace conflict like this and requests
    to resolve this type of conflicts:
    https://fedoraproject.org/wiki/Packaging/Conflicts#Conflicting_Files

    I think
    - %_libdir/libopenal.so should be renamed to libopenal-soft.so
    - %_bindir/openal-info should be renamed to openal-soft-info
    - %_includedir/AL should be renamed to %_includedir/openal-soft
      or so (anyway the directory name "AL" is too short)
    - %_libdir/pkgconfig/openal.so should be renamed to openal-soft.pc
      and its contents should be modified to respect includedir
      name change
    - %_bindir/openal-config

(In reply to comment #5)
> (In reply to comment #3)
> > (Removing NEEDSPONSOR)  
> 
> Mamoru, I'm willing to sponsor Thomas after this review because he is a friend
> of mine.  

- Well, I don't know how to change sponsor of one person on FAS...
  Anyway you can help Thomas in any way and I am happy with it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.