[Bug 508510] Review Request: python-Scriptaculous - Scriptaculous packaged as TurboGears widgets.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508510


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review?




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-06-29 05:17:20 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1439466
+ rpmlint output for SRPM and for RPM.
python-Scriptaculous.noarch: E: zero-length
/usr/lib/python2.6/site-packages/Scriptaculous-1.8.2-py2.6.egg-info/not-zip-safe
==> can be ignored I guess as these are zero length files.
+ source files match upstream url
f01e40103607f5255e624e216c2bd1d52e86435a  Scriptaculous-1.8.2.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

Sugeestions:
1) Source URL should be

http://pypi.python.org/packages/source/L/Scriptaculous/Scriptaculous-%{version}.tar.gz

2) %doc should be
%doc README.txt PKG-INFO

3) Why there is some comments related to LICENSE file? Remove that.

4) Change %define to %global

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.