[Bug 508075] Review Request: php-pear-HTML-Javascript - Class for creating simple JS scripts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508075


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-06-29 13:58:10 EDT ---
Some notes:

* Naming
  - I think this srpm must be named as just php-pear-HTML_Javascript.

* Directory ownership issue / %files entry
  - (At least) on rawhide %{pear_phpdir}/ is expanded as /usr/share/pear
    so
-------------------------------------------------------------
%files
%{pear_phpdir}/*
-------------------------------------------------------------
    contains all files/directories/etc under /usr/share/pear.

    On the other hand %{pear_xmldir} as /usr/share/pear/.pkgxml 
    and %{pear_testdir} as /usr/share/pear/test, so current %files
    entry causes duplicate file list:
-------------------------------------------------------------
warning: File listed twice: /usr/share/pear/test/HTML_Javascript
warning: File listed twice: /usr/share/pear/test/HTML_Javascript/tests
warning: File listed twice: /usr/share/pear/test/HTML_Javascript/tests/js.php
warning: File listed twice:
/usr/share/pear/test/HTML_Javascript/tests/output.php
-------------------------------------------------------------
  - Also the following directories (themselves) are already owned 
    by php-common so this rpm should not own them.
-------------------------------------------------------------
/usr/share/pear/doc
/usr/share/pear/test
-------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.