[Bug 507053] Review Request: latrace - glibc 2.4+ LD_AUDIT feature frontend

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507053





--- Comment #1 from Dan Horák <dan at danny.cz>  2009-06-30 05:53:57 EDT ---
some notes
- tool name shouldn't be repeated in summary (e.g. LD_AUDIT feature frontend
for glibc 2.4+), but IMHO it should be description
- license tag should be GPLv3+, because you have "GPLv3 or any later version"
in the sources
- s/dl/download/ in the URL tag
(https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net)
- at least bison, asciidoc and xmlto are missing in the BuildRequires - you
should try building the package in mock to find all the BRs
- run make with V=1 in %build, options passed to gcc must be visible
- doesn't build in Rawhide, I get an error
...
Note: Writing latrace.1
  ASCIIDOC doc/latrace.html
ERROR: unsafe: include file: /etc/asciidoc/./stylesheets/xhtml11.css
ERROR: unsafe: include file: /etc/asciidoc/./stylesheets/xhtml11-manpage.css
ERROR: unsafe: include file: /etc/asciidoc/./stylesheets/xhtml11-quirks.css
make: *** [doc/latrace.html] Error 1
chyba: Špatný návratový kód z /var/tmp/rpm-tmp.q7Pndh (%install)
chyby sestavení RPM:
...

- 32-bit Intel platform should be encoded as "%{ix86}" in the ExclusiveArch tag
and ARM in lowercase
- don't mark the man page as %doc

Increase the release in next published iteration of the package if the version
remains the same.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.