[Bug 497194] Review Request: liblastfm - Libraries to integrate Last.fm services

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497194





--- Comment #5 from Eelko Berkenpies <fedora at berkenpies.nl>  2009-06-30 10:14:26 EDT ---
[V] MUST: rpmlint must be run on every package. The output should be posted in
the review.

[eelko at eb SPECS]$ rpmlint
/home/eelko/rpmbuild/SRPMS/liblastfm-0.3.0-2.fc11.src.rpm
liblastfm.src:41: W: configure-without-libdir-spec
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[eelko at eb SPECS]$ rpmlint
/home/eelko/rpmbuild/RPMS/i586/liblastfm-0.3.0-2.fc11.i586.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[eelko at eb SPECS]$ rpmlint
/home/eelko/rpmbuild/RPMS/i586/liblastfm-devel-0.3.0-2.fc11.i586.rpm
liblastfm-devel.i586: W: no-dependency-on liblastfm/liblastfm-libs/libliblastfm
liblastfm-devel.i586: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
[eelko at eb SPECS]$ rpmlint
/home/eelko/rpmbuild/RPMS/i586/liblastfm-debuginfo-0.3.0-2.fc11.i586.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[V] MUST: All build dependencies must be listed in BuildRequires, except for
any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.

Conclusion:
------------------
APPROVED
------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.