[Bug 492203] Review Request: frinika - Music Workstation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492203





--- Comment #7 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-06-30 17:31:06 EDT ---
(In reply to comment #6)
> (In reply to comment #5)
> 
> Example how I think about it (both revision number as parameter, and "svn
> export" here) - http://hubbitus.fedorapeople.org/frinika-snapshot.sh
> 
> Hope if it help. And off course I do not insist on exactly that 
> implementation.
> 

Okay, I used your script and I also made an option to do
   $ sh frinika-snapshot.sh latest
to get the latest sources (which is nice when doing updates)

> $ ant jar javadocs
> 

I noticed that ant is pulled by other BR's. But I added it anyways.


> > The patches are all strictly Fedora specific. I'll add a comment.
> Really all Fedora related? I think frinika-sevenzip.patch fix real bug. Why 
> you do not wish fill it upstream?
> 

The patch is not needed for the SevenZip that is in the frinika tarball. It is
specific for the SevenZip we have in Fedora.

> 
> > > Should:
> > > [=] I think in command:
> > > ln -s %{_libdir}/flexdock/flexdock-0.5.1.jar lib/flexdock.jar || \ 
> > > Will be cool replace "0.5.1" by something like %{version}
> > That 0.5.1 is flexdock's version, not frinika's.  
> Really. My mistake. But it is also error. You use unversioned
> BuildRequires:    flexdock
> Requires:         flexdock
> but symlink to exact version of jar.
> 

This was a flexdock packaging bug (bug #464781 comment #45). The unversioned
jar symlink was not available (in all repos) when I first packaged frinika. But
I see that it is fixed in all repos now. So I removed my workaround.

> From this I look again on this symlinks. I think instead of doing such symlink
> you should use build-classpath:
> http://fedoraproject.org/wiki/Packaging:Java#build-classpath  

build-classpath only works for jar files that go to %{_javadir}. As indicated
in
   http://fedoraproject.org/wiki/Packaging:Java#Guideline
the JNI using jar files go to %{_libdir}/%{name} and build-classpath will not
work on them. They need to be added manually.


I updated the package (also fixed the other issues you pointed):
Spec URL: http://oget.fedorapeople.org/review/frinika.spec
SRPM URL:
http://oget.fedorapeople.org/review/frinika-0.5.1-4.548svn.fc11.src.rpm

ChangeLog: 0.5.1-4.548svn
- Update to svn revision 548
- License is GPLv2+
- Add BR: ant
- Add more comments on sources & patches
- Make the snapshot script nicer (thanks to Pavel Alexeev)
- Remove flexdock versioned symlink workaround
- Remove some unneeded sources


So, I removed the Dknob sources from src/com/dreamfabric/ . As far as I can
tell, they are not used by frinika. I think the only remaining issues are these
additional sources. I asked about them (Dknob and others) upstream 
   https://sourceforge.net/forum/forum.php?thread_id=3319021&forum_id=447356
They usually respond fast. Let us wait and see what will come out.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.