[Bug 225612] Merge Review: beagle

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225612


Tom "spot" Callaway <tcallawa at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #4 from Tom "spot" Callaway <tcallawa at redhat.com>  2009-03-02 08:46:01 EDT ---
Looks like rpmlint caught one missing -x case, you should add:

find $RPM_BUILD_ROOT -name '*.css' -exec chmod a-x {} ';'

Two more things I noticed:

* the -devel package probably needs to have a Requires: %{name} =
%{version}-%{release}

* You should get rid of the userdel/groupdel commands in %post. Removing users
is dangerous enough (what if a user chooses "beagleindex" for their username?),
and this particular username hasn't been used in a beagle package since before
Fedora 7.

== Review ==
- rpmlint checks return:
beagle.src: W: strange-permission beagle-thunderbird-update.sh 0775
beagle.x86_64: W: non-standard-uid /var/cache/beagle beaglidx
beagle.x86_64: W: non-standard-gid /var/cache/beagle beaglidx
beagle.x86_64: W: non-conffile-in-etc
/etc/xdg/autostart/beagled-autostart.desktop
beagle.x86_64: W: devel-file-in-non-devel-package /usr/bin/beagle-config
beagle.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/beagle/libbeagleglue.so
beagle.x86_64: W: non-conffile-in-etc /etc/beagle/external-filters.xml.sample
beagle.x86_64: W: non-standard-uid /var/cache/beagle/indexes beaglidx
beagle.x86_64: W: non-standard-gid /var/cache/beagle/indexes beaglidx
beagle.x86_64: E: explicit-lib-dependency libbeagle
beagle.x86_64: W: dangerous-command-in-%post rm
beagle.x86_64: W: dangerous-command-in-%preun rm
beagle-gnome.x86_64: W: no-documentation
beagle-gnome.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/beagle/libbeagleuiglue.so
beagle-evolution.x86_64: W: no-documentation
beagle-evolution.x86_64: E: only-non-binary-in-usr-lib
beagle-thunderbird.x86_64: W: no-documentation
beagle-thunderbird.x86_64: E: only-non-binary-in-usr-lib
beagle-firefox.x86_64: W: no-documentation
beagle-firefox.x86_64: E: script-without-shebang
/usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/skin/classic/overlay.css
beagle-firefox.x86_64: E: only-non-binary-in-usr-lib
beagle-epiphany.x86_64: W: no-documentation
beagle-epiphany.x86_64: E: only-non-binary-in-usr-lib
beagle-devel.x86_64: E: only-non-binary-in-usr-lib

All safe to ignore, except the executable .css.

- package meets naming guidelines
- package meets packaging guidelines
- license (ASL 2.0 and MIT and BSD and CC-BY and LGPLv2+ and (AFL or LGPLv2+))
OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream 
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok (except for one .css file)
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop files okay
- devel package ok (except for missing requires)
- no .la files
- post/postun ldconfig not needed for mono

== 
With those three items above resolved, I will approve this review.

Thanks in advance.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.